RFR: 8260528: Clean glass-gtk sizing and positioning code [v27]

Thiago Milczarek Sayao tsayao at openjdk.org
Thu Nov 24 10:53:19 UTC 2022


On Fri, 18 Nov 2022 11:40:56 GMT, Thiago Milczarek Sayao <tsayao at openjdk.org> wrote:

>> modules/javafx.graphics/src/main/native-glass/gtk/glass_window.cpp line 1047:
>> 
>>> 1045: 
>>> 1046:     if (moved) {
>>> 1047:         geometry_set_window_x(&geometry, x);
>> 
>> this will set `windowGeometry->refx` where 2 lines below you set `windowGeometry.current_x`. Unless there is gravity involved, both refer to the same value, one being `int` and the other being `float` though. Is there another conceptual difference, or why do we have 2 values here?
>
> I think you're right, I added `current_x/y` to check if a window moved, but `ref_x/ref_y` might contain the same value (different type).

Fixed

-------------

PR: https://git.openjdk.org/jfx/pull/915


More information about the openjfx-dev mailing list