Integrated: 8297130: ComboBox popup doesn't close after selecting value that was added with 'runLater'

Michael Strauß mstrauss at openjdk.org
Thu Nov 24 15:55:51 UTC 2022


On Sat, 19 Nov 2022 18:01:41 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

> This PR fixes a bug where multi-level focus is not correctly preserved.
> The original implementation incorrectly assumed that there can only be a single focused node in the scene graph, which is not the case when a branch of the scene graph is presented by a `PopupWindow`. More specifically, when a focused node was removed from the scene graph, the focus flags of all parents were incorrectly cleared. The correct implementation only clears the `focusWithin` flag of parents (but not `focused` or `focusVisible`), and stops when another focused node is encountered along the way.

This pull request has now been integrated.

Changeset: 4a697f1a
Author:    Michael Strauß <mstrauss at openjdk.org>
URL:       https://git.openjdk.org/jfx/commit/4a697f1afc5f8e850425f5934ee1bcb73dd5da9f
Stats:     69 lines in 2 files changed: 57 ins; 3 del; 9 mod

8297130: ComboBox popup doesn't close after selecting value that was added with 'runLater'

Reviewed-by: angorya, aghaisas

-------------

PR: https://git.openjdk.org/jfx/pull/956


More information about the openjfx-dev mailing list