RFR: 8265828: [TestBug] Save and restore the default Locale in javafx.base unit test LocalDateTimeStringConverterTest [v4]

Mon Nov 28 14:58:25 UTC 2022

On Mon, 28 Nov 2022 14:56:49 GMT, Lukasz Kostyra <duke at openjdk.org> wrote:

>> The change moves Locale setting in the test to `@BeforeClass` and `@AfterClass` calls. `@BeforeClass` method call stores current default VM locale and applies Locale.US, while `@AfterClass` method restores old VM locale after all tests are completed.
>> 
>> I tested it both on Mac and Windows, in both cases Locale is changed, restored properly and tests pass.
>
> Lukasz Kostyra has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove trailing whitespaces

The refactoring looks good to me. I left a few comments on one of the tests. Those comments apply to all of them.

-------------

PR: https://git.openjdk.org/jfx/pull/954