RFR: JDK-8297412: Remove easy warnings in javafx.fxml, javafx.media, javafx.swing, javafx.swt and javafx.web [v2]
John Hendrikx
jhendrikx at openjdk.org
Mon Nov 28 17:04:20 UTC 2022
On Tue, 22 Nov 2022 19:10:27 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line 1446:
>>
>>> 1444: }
>>> 1445: }
>>> 1446:
>>
>> this suggests a specific pattern, even though there is probably no development expected in this class.
>> i'd keep it as is, and revert making the method abstract in the base class.
>
> I agree. This sort of change goes beyond what I expect to see in a cleanup pass.
I've reverted these changes and documented the exception instead.
Also resolved all other conversations with the same root cause.
-------------
PR: https://git.openjdk.org/jfx/pull/958
More information about the openjfx-dev
mailing list