RFR: 8294589: MenuBarSkin: memory leak when changing skin [v11]
Andy Goryachev
angorya at openjdk.org
Mon Nov 28 18:03:26 UTC 2022
> Fixed memory leak by using weak listeners and making sure to undo everything that has been done to MenuBar/Skin in dispose().
>
> This PR depends on a new internal class ListenerHelper, a replacement for LambdaMultiplePropertyChangeListenerHandler.
> See https://github.com/openjdk/jfx/pull/908
Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 43 commits:
- Merge remote-tracking branch 'origin/master' into
8294589.menubarskin.leak
- Merge branch '8294809.listener.helper' into 8294589.menubarskin.leak
- 8294809: generics
- 8294589: owner
- Merge branch '8294809.listener.helper' into 8294589.menubarskin.leak
- 8294809: is alive
- Merge branch '8294809.listener.helper' into 8294589.menubarskin.leak
- Revert "8294809: removed weak listeners support"
This reverts commit 2df4a85db638d76cacaf6c54ba669cdb3dd91a18.
- Revert "8294589: removed weak listeners"
This reverts commit 2ea27fc912178cf2f22155794e047f20950d0d7d.
- 8294589: removed weak listeners
- ... and 33 more: https://git.openjdk.org/jfx/compare/3376228a...f2ec9169
-------------
Changes: https://git.openjdk.org/jfx/pull/906/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=906&range=10
Stats: 456 lines in 4 files changed: 237 ins; 190 del; 29 mod
Patch: https://git.openjdk.org/jfx/pull/906.diff
Fetch: git fetch https://git.openjdk.org/jfx pull/906/head:pull/906
PR: https://git.openjdk.org/jfx/pull/906
More information about the openjfx-dev
mailing list