RFR: JDK-8297414: Remove easy warnings in javafx.controls [v7]

John Hendrikx jhendrikx at openjdk.org
Tue Nov 29 08:00:23 UTC 2022


On Mon, 28 Nov 2022 23:32:57 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix some indents and put declarations on one line where possible
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/SliderTest.java line 60:
> 
>> 58:         tk = Toolkit.getToolkit();
>> 59: 
>> 60:         assertTrue(tk instanceof StubToolkit);  // Ensure it's StubToolkit
> 
> I still think that we should create 
> 
> public static Toolkit Util.loadStubToolkit()?
> 
> with a javadoc that explains why it is needed.

I commented on this in another comment, would like to close this topic for now.

-------------

PR: https://git.openjdk.org/jfx/pull/959


More information about the openjfx-dev mailing list