RFR: 8265828: [TestBug] Save and restore the default Locale in javafx.base unit test LocalDateTimeStringConverterTest [v4]

[Lukasz Kostyra]

On Mon, 28 Nov 2022 16:07:34 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Lukasz Kostyra has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove trailing whitespaces
>
> modules/javafx.base/src/test/java/test/javafx/util/converter/LocalDateTimeStringConverterTest.java line 156:
> 
>> 154: 
>> 155:     @After
>> 156:     public void teardown() {
> 
> is this method empty?  can it be removed?

Done

> modules/javafx.base/src/test/java/test/javafx/util/converter/LocalTimeStringConverterTest.java line 131:
> 
>> 129:                 this.converter = new LocalTimeStringConverter();
>> 130:                 this.locale = Locale.getDefault(Locale.Category.FORMAT);
>> 131:                 // this.formatter and this.parser remain null
> 
> I think it would be better to set these to null explicitly here and WITH_FORMAT_STYLES.
> this way you don't need to rely on some far away code and assumptions.

Done

> modules/javafx.base/src/test/java/test/javafx/util/converter/LocalTimeStringConverterTest.java line 151:
> 
>> 149: 
>> 150:     @After
>> 151:     public void teardown() {
> 
> can this method be removed?

Done

-------------

PR: https://git.openjdk.org/jfx/pull/954