RFR: 8265828: [TestBug] Save and restore the default Locale in javafx.base unit test LocalDateTimeStringConverterTest [v5]
Lukasz Kostyra
duke at openjdk.org
Tue Nov 29 11:34:02 UTC 2022
> The change moves Locale setting in the test to `@BeforeClass` and `@AfterClass` calls. `@BeforeClass` method call stores current default VM locale and applies Locale.US, while `@AfterClass` method restores old VM locale after all tests are completed.
>
> I tested it both on Mac and Windows, in both cases Locale is changed, restored properly and tests pass.
Lukasz Kostyra has updated the pull request incrementally with one additional commit since the last revision:
Fix code review comments
-------------
Changes:
- all: https://git.openjdk.org/jfx/pull/954/files
- new: https://git.openjdk.org/jfx/pull/954/files/e5cd522b..b1db3c0f
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jfx&pr=954&range=04
- incr: https://webrevs.openjdk.org/?repo=jfx&pr=954&range=03-04
Stats: 81 lines in 3 files changed: 0 ins; 15 del; 66 mod
Patch: https://git.openjdk.org/jfx/pull/954.diff
Fetch: git fetch https://git.openjdk.org/jfx pull/954/head:pull/954
PR: https://git.openjdk.org/jfx/pull/954
More information about the openjfx-dev
mailing list