RFR: JDK-8297412: Remove easy warnings in javafx.fxml, javafx.media, javafx.swing, javafx.swt and javafx.web [v5]

Andy Goryachev angorya at openjdk.org
Tue Nov 29 16:55:43 UTC 2022


On Mon, 28 Nov 2022 17:04:17 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

>> - Remove unsupported/unnecessary SuppressWarning annotations
>> - Remove reduntant type specifications (use diamond operator)
>> - Remove unused or duplicate imports
>> - Remove unnecessary casts (type is already correct type or can be autoboxed)
>> - Remove unnecessary semi-colons (at end of class definitions, or just repeated ones)
>> - Remove redundant super interfaces (interface that is already inherited)
>> - Remove unused type parameters
>> - Remove declared checked exceptions that are never thrown
>> - Add missing `@Override` annotations
>
> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert change of private class to abstract in FXMLLoader
>   
>   Exception is now documented instead

looks good now

-------------

Marked as reviewed by angorya (Author).

PR: https://git.openjdk.org/jfx/pull/958


More information about the openjfx-dev mailing list