RFR: JDK-8297414: Remove easy warnings in javafx.controls [v9]

John Hendrikx jhendrikx at openjdk.org
Tue Nov 29 21:58:38 UTC 2022


> Note: I ran into a `javac` compiler bug while replacing types with diamond operators (ecj has no issues).  I had two options, add a `SuppressWarnings("unused")` or to use a lambda instead of a method reference to make `javac` happy.  I choose the later and added a comment so it can be fixed once the bug is fixed.  I've reported the issue here: https://bugs.openjdk.org/browse/JDK-8297428
> 
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be autoboxed)
> - Remove unnecessary semi-colons (at end of class definitions, or just repeated ones)
> - Remove redundant super interfaces (interface that is already inherited)
> - Remove unused type parameters
> - Remove declared checked exceptions that are never thrown
> - Add missing `@Override` annotations

John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:

  Revert redundant super interface changes

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/959/files
  - new: https://git.openjdk.org/jfx/pull/959/files/1697bd1d..3553612f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=959&range=08
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=959&range=07-08

  Stats: 4 lines in 2 files changed: 2 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jfx/pull/959.diff
  Fetch: git fetch https://git.openjdk.org/jfx pull/959/head:pull/959

PR: https://git.openjdk.org/jfx/pull/959


More information about the openjfx-dev mailing list