RFR: JDK-8297413: Remove easy warnings in javafx.graphics [v2]
Nir Lisker
nlisker at openjdk.org
Wed Nov 30 03:24:24 UTC 2022
On Tue, 22 Nov 2022 21:30:09 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix indentation
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/WindowStage.java line 418:
>
>> 416: scaleFactor = 1.0 / scaleDivider;
>> 417: adjw = (int)Math.round(iw / scaleDivider);
>> 418: adjh = (int)Math.round(ih / scaleDivider);
>
> Same comment here about the old code being clearer.
`scaleDivider` is defined just 2 lines above as a `double`. I don't see how the cast helps here.
-------------
PR: https://git.openjdk.org/jfx/pull/960
More information about the openjfx-dev
mailing list