RFR: 8296409: Multiple copies of accelerator change listeners are added to MenuItems, but only 1 is removed

[Andy Goryachev]

On Tue, 8 Nov 2022 10:11:40 GMT, Dean Wookey <dwookey at openjdk.org> wrote:

>> Reviewers: @arapte @andy-goryachev-oracle
>
> @kevinrushforth, @arapte I clicked the request review on andy and it removed arapte for some reason. I guess that button shouldn't be clicked. Oops.

@DeanWookey : 
Would it be possible to modify this PR to use the alternative solution https://github.com/openjdk/jfx/commit/80971d89c46f3f74cb8584d4907cc6818809e2f6 ?  I think the code in this PR as it stands right now removes a bit of functionality that is needed, while the alternative does not.

Also, would it be possible to base your changes on top of https://github.com/openjdk/jfx/pull/919 since the skin got reworked to eliminate a memory leak, and it might be easier to base your changes on top of that rather than try to resolve non-trivial merge conflicts.

What do you think?

-------------

PR: https://git.openjdk.org/jfx/pull/937