RFR: 8294589: MenuBarSkin: memory leak when changing skin [v16]

Andy Goryachev angorya at openjdk.org
Wed Nov 30 23:37:48 UTC 2022


> Fixed memory leak by using weak listeners and making sure to undo everything that has been done to MenuBar/Skin in dispose().
> 
> This PR depends on a new internal class ListenerHelper, a replacement for LambdaMultiplePropertyChangeListenerHandler.
> See https://github.com/openjdk/jfx/pull/908

Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:

  8294589: review comments

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/906/files
  - new: https://git.openjdk.org/jfx/pull/906/files/2a9d2095..bdb8d828

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=906&range=15
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=906&range=14-15

  Stats: 66 lines in 1 file changed: 17 ins; 18 del; 31 mod
  Patch: https://git.openjdk.org/jfx/pull/906.diff
  Fetch: git fetch https://git.openjdk.org/jfx pull/906/head:pull/906

PR: https://git.openjdk.org/jfx/pull/906


More information about the openjfx-dev mailing list