RFR: 8293795: [Accessibility] [Win] [Narrator] Exceptions when deleting text with continous key press in TextArea and TextField [v3]
Ambarish Rapte
arapte at openjdk.org
Mon Oct 3 14:40:29 UTC 2022
On Mon, 3 Oct 2022 13:25:00 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision:
>>
>> call validateRange() on line 236-237
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/win/WinTextRangeProvider.java line 95:
>
>> 93:
>> 94: private void validateRange() {
>> 95: String text = (String)getAttribute(TEXT);
>
> It looks like you already have the `text` everywhere you call this. You might consider passing it in as a parameter rather than calling `getAttribute` redundantly.
Thanks for the review.
Addressed both the comments. Please take a re-look.
-------------
PR: https://git.openjdk.org/jfx/pull/907
More information about the openjfx-dev
mailing list