RFR: 8290844: Add Skin.install() method [v9]
Kevin Rushforth
kcr at openjdk.org
Mon Oct 3 18:17:39 UTC 2022
On Thu, 29 Sep 2022 15:58:01 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> - added Skin.install()
>> - javadoc changes for Skinnable.setSkin(Skin)
>
> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 20 additional commits since the last revision:
>
> - Merge branch 'openjdk:master' into 8290844.skin.install
> - 8290844: unit tests
> - Merge remote-tracking branch 'origin/master' into 8290844.skin.install
> - 8290844: review comments
> - 8290844: review comments
> - Merge remote-tracking branch 'origin/master' into 8290844.skin.install
> - 8290844: review comments
> - 8290844: review comments
> - Merge remote-tracking branch 'origin/master' into 8290844.skin.install
> - 8290844: javadoc
> - ... and 10 more: https://git.openjdk.org/jfx/compare/c03446c3...d954aafc
@johanvos Do you have any thoughts on this enhancement? I'm most interested whether you extend any of the built-in JavaFX skin classes in a way that it might cause problems for you if they move some of their setup code from their constructor to their `install` method?
-------------
PR: https://git.openjdk.org/jfx/pull/845
More information about the openjfx-dev
mailing list