RFR: 8294589: MenuBarSkin: memory leak when changing skin

[Jeanette Winzenburg]

On Fri, 30 Sep 2022 15:06:19 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/SkinMemoryLeakTest.java line 94:
>> 
>>> 92:     public void testMemoryLeakSameSkinClass() {
>>> 93:         showControl(control, true);
>>> 94:         installDefaultSkin(control);
>> 
>> no - here we test the isolated skin installation, no need for actually showing it. Please don't change the semantic of existing tests.
>
> So here we have a problem - I know that the memory leak is fixed (I've tested using VisualVM in a real application), but without this change, or without adding a StageLoader, the test fails.
> Any suggestions?

hmm, no direct idea but ... sounds like it's not fixed completely: first step would be to track down why it fails for this particular skin and what exactly is different from all other skins (that are fixed so far). If it turns out that there's something special, you can do the special memory testing in SkinCleanupTest (with documentation why that's required).

-------------

PR: https://git.openjdk.org/jfx/pull/906