RFR: 8294589: MenuBarSkin: memory leak when changing skin

[Andy Goryachev]

On Fri, 30 Sep 2022 16:15:23 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

>> See https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java
>
> okay, not tested (so treat it as just a wild guess :) - there is this listener on the skinnable's sceneProperty: it's installed only when there's no scene and removed once the scene is set. Without showing, it looks like it's never removed (as it must!)
> 
> Unrelated: also look at your dispose: it's violating its contract (making SkinDisposeContractTest fail)

Will definitely do!  Some tests were failing yesterday, until all is fixed - it's a draft PR :-)
Thank you so much, @kleopatra

-------------

PR: https://git.openjdk.org/jfx/pull/906