RFR: 8290844: Add Skin.install() method [v9]

Johan Vos jvos at openjdk.org
Tue Oct 4 09:28:27 UTC 2022


On Thu, 29 Sep 2022 15:58:01 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> - added Skin.install()
>> - javadoc changes for Skinnable.setSkin(Skin)
>
> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 20 additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into 8290844.skin.install
>  - 8290844: unit tests
>  - Merge remote-tracking branch 'origin/master' into 8290844.skin.install
>  - 8290844: review comments
>  - 8290844: review comments
>  - Merge remote-tracking branch 'origin/master' into 8290844.skin.install
>  - 8290844: review comments
>  - 8290844: review comments
>  - Merge remote-tracking branch 'origin/master' into 8290844.skin.install
>  - 8290844: javadoc
>  - ... and 10 more: https://git.openjdk.org/jfx/compare/09fb97b3...d954aafc

modules/javafx.controls/src/main/java/javafx/scene/control/Control.java line 229:

> 227:      * against this Control, and throw an {@code IllegalArgumentException} if it is not the same.
> 228:      * <p>
> 229:      * A skin may be null.

This breaks the 1-1 relationship mentioned above, so it's probably best to mention this as an exception to the 1-1 rule.

-------------

PR: https://git.openjdk.org/jfx/pull/845


More information about the openjfx-dev mailing list