RFR: 8290844: Add Skin.install() method [v9]

[Johan Vos]

On Thu, 29 Sep 2022 15:58:01 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> - added Skin.install()
>> - javadoc changes for Skinnable.setSkin(Skin)
>
> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 20 additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into 8290844.skin.install
>  - 8290844: unit tests
>  - Merge remote-tracking branch 'origin/master' into 8290844.skin.install
>  - 8290844: review comments
>  - 8290844: review comments
>  - Merge remote-tracking branch 'origin/master' into 8290844.skin.install
>  - 8290844: review comments
>  - 8290844: review comments
>  - Merge remote-tracking branch 'origin/master' into 8290844.skin.install
>  - 8290844: javadoc
>  - ... and 10 more: https://git.openjdk.org/jfx/compare/b96c7ef1...d954aafc

modules/javafx.controls/src/main/java/javafx/scene/control/Skin.java line 83:

> 81:      *
> 82:      * @implNote
> 83:      * Most implementations of Skin in the <code>javafx.controls</code> module

If this is only targeting controls in the javafx.controls module, it is not relevant to developers using JavaFX.

modules/javafx.controls/src/main/java/javafx/scene/control/Skinnable.java line 43:

> 41:      * It listens and responds to changes in state in a {@code Skinnable}.
> 42:      * <p>
> 43:      * There is typically a one-to-one relationship between a {@code Skinnable} and its

The word "typically" doesn't describe when this applies and when not. From the previous comments, I get a better understanding (PopupControl), but developers reading the JavaDoc won't see that.

-------------

PR: https://git.openjdk.org/jfx/pull/845