RFR: 8294589: MenuBarSkin: memory leak when changing skin

Jeanette Winzenburg fastegal at openjdk.org
Tue Oct 4 14:50:39 UTC 2022


On Thu, 29 Sep 2022 23:00:17 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

> Fixed memory leak by using weak listeners and making sure to undo everything that has been done to MenuBar/Skin in dispose().

modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/LambdaMultiplePropertyChangeListenerHandler.java line 183:

> 181:                     consumer.accept(v);
> 182:                 }
> 183:             });

beware: unregister removes _all_ listeners (of type InvalidationListener) from the given property

-------------

PR: https://git.openjdk.org/jfx/pull/906


More information about the openjfx-dev mailing list