RFR: 8290844: Add Skin.install() method [v9]

Jeanette Winzenburg fastegal at openjdk.org
Tue Oct 4 16:09:40 UTC 2022


On Thu, 29 Sep 2022 15:58:01 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> - added Skin.install()
>> - javadoc changes for Skinnable.setSkin(Skin)
>
> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 20 additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into 8290844.skin.install
>  - 8290844: unit tests
>  - Merge remote-tracking branch 'origin/master' into 8290844.skin.install
>  - 8290844: review comments
>  - 8290844: review comments
>  - Merge remote-tracking branch 'origin/master' into 8290844.skin.install
>  - 8290844: review comments
>  - 8290844: review comments
>  - Merge remote-tracking branch 'origin/master' into 8290844.skin.install
>  - 8290844: javadoc
>  - ... and 10 more: https://git.openjdk.org/jfx/compare/aa698f12...d954aafc

modules/javafx.controls/src/main/java/javafx/scene/control/Skin.java line 90:

> 88:      */
> 89:     default public void install() { }
> 90: 

what about calling install more than once? There are arguments for either:

- in symmetry to dispose, it should be allowed 
- regarding this as an "out-sourced" part of the constructor - to allow/enforce proper cleanup - it shouldn't

whatever the decision, it must be specified

-------------

PR: https://git.openjdk.org/jfx/pull/845


More information about the openjfx-dev mailing list