RFR: 8294589: MenuBarSkin: memory leak when changing skin

[Jeanette Winzenburg]

On Tue, 4 Oct 2022 20:29:05 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

> I have a string feeling that this PR should go back to DRAFT state, pending a better listener helper implementation JDK-8294809. Also, this particular skin may need to get it's listeners refactored - I see two scene listeners which seems redundant.

don't worry: you choose one of the hardest skins to fix as your first - only the comboXX are worse ;) 

- it has OS-specifics
- it needs listeners/handlers on the scene which are very tricky to get right on and off
- it's unusual in not having a behavior (that's where the event handlers should reside)
- it has nested menus (which are problematic in themselves)
- .. probably more :)

-------------

PR: https://git.openjdk.org/jfx/pull/906