RFR: 8290844: Add Skin.install() method [v9]

Jeanette Winzenburg fastegal at openjdk.org
Wed Oct 5 12:42:38 UTC 2022


On Tue, 4 Oct 2022 19:22:42 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> so maybe `setting the {@link #skinProperty() skin property}`?
>
> please check the updated comment, I think it sounds weird...

that change sounds okay to me :) 

What might be missing is a description of that it actually does, that is taking full control about the old.dispose / new.install sequence as spec'ed in Skin - I think it could be repeated here to emphasize that it's living up to its responsibility.

-------------

PR: https://git.openjdk.org/jfx/pull/845


More information about the openjfx-dev mailing list