RFR: 8290844: Add Skin.install() method [v11]

[Andy Goryachev]

On Fri, 7 Oct 2022 22:51:07 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 24 additional commits since the last revision:
>> 
>>  - Merge remote-tracking branch 'origin/master' into 8290844.skin.install
>>  - 8290844: javadoc
>>  - Merge remote-tracking branch 'origin/master' into 8290844.skin.install
>>  - 8290844: javadoc
>>  - Merge branch 'openjdk:master' into 8290844.skin.install
>>  - 8290844: unit tests
>>  - Merge remote-tracking branch 'origin/master' into 8290844.skin.install
>>  - 8290844: review comments
>>  - 8290844: review comments
>>  - Merge remote-tracking branch 'origin/master' into 8290844.skin.install
>>  - ... and 14 more: https://git.openjdk.org/jfx/compare/a785e7c0...15731a2c
>
> modules/javafx.controls/src/main/java/javafx/scene/control/Control.java line 232:
> 
>> 230:      * to complete the process.  Only inside of {@link Skin#install()} should {@code Skin} implementations
>> 231:      * set/overwrite properties of their {@code Control} (though commutative operations like add/remove listener
>> 232:      * can still be done in the {@code Skin} constructor.
> 
> I don't think "commutative" is quite the right term here, although I get what you are saying. This is trying to describe an operation that can be reversed (undone) without side effect. So commutativity is part of it, but not the whole thing. The property we want is:
> 
> 
> f(A, A`) == empty
> f(A, B, B`) == f(A)
> f(A, B, A`) == f(B)
> 
> 
> Is there a single term that describes this?
> 
> Oh, and you are missing a closing parenthesis.

re-phrased.

-------------

PR: https://git.openjdk.org/jfx/pull/845