RFR: 8287822: [macos] Remove support of duplicated formats from macOS [v3]

Andy Goryachev angorya at openjdk.org
Thu Oct 13 22:29:13 UTC 2022


On Thu, 13 Oct 2022 04:25:19 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

>> - Added support for JAR and JRT protocol to AVFoundation platform.
>>  - Removed H.264/MP3 and AAC support from GStreamer platform, which was primary used to playback these formats for JAR and JRT protocols.
>>  - Added ability to FXMediaPlayer sample to generate playlist for JAR and JRT protocols for testing. See FXMedia.java for how to use it.
>>  - H.265/HEVC via JAR/JRT protocols should work on macOS after this change. Before it did not work because GStreamer platform did not support H.265/HEVC and AVFoundation did not support JAR/JRT protocols.
>>  - Minor code clean up.
>> 
>> After this changes:
>> GSTPlatform: AIFF and WAV for all protocols.
>> AVFoundation: MP3, AAC, HLS, H.264 and H.265 for all protocols.
>> 
>> This change is transparent for end user and does not affect list of supported formats by JavaFX Media.
>
> Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8287822: [macos] Remove support of duplicated formats from macOS [v3]

Changes requested by angorya (Author).

tests/manual/media/FXMediaPlayer/src/fxmediaplayer/media/FXMedia.java line 118:

> 116:                     path = fileSystem.getPath("fxmediaplayer", "media");
> 117:                 } else {
> 118:                     path = Path.of(uri);

should we explicitly check if it is a file?
if("file".equals(uri.getScheme()) { ...

-------------

PR: https://git.openjdk.org/jfx/pull/909


More information about the openjfx-dev mailing list