RFR: 8290040: Provide simplified deterministic way to manage listeners [v6]

Andy Goryachev angorya at openjdk.org
Fri Oct 14 21:36:05 UTC 2022


On Fri, 14 Oct 2022 21:04:58 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

>> modules/javafx.base/src/test/java/test/javafx/beans/value/ObservableValueFluentBindingsTest.java line 1162:
>> 
>>> 1160:                 }
>>> 1161:             }
>>> 1162:         }
>> 
>> Is it possible to add the scenario that simulates configurations you so beautifully illustrated in the comments in this PR?  For example, simulate the removal of the "Skin" (without involving a real Skin implementation, just re-create the classes and properties in the same configuration)?
>
> You mean something like calling `setSkin` on a `Button` in a loop with a new skin that uses this form of listener management?  And seeing if the old skin instances don't stick around?
> 
> I suppose I could make a copy of one of the smaller skins, tweak it to use `when` and then testing this. Is that what you'd be looking for?

never mind, please disregard.

-------------

PR: https://git.openjdk.org/jfx/pull/830


More information about the openjfx-dev mailing list