RFR: 8243115: Spurious invalidations due to bug in IntegerBinding and other classes

Kevin Rushforth kcr at openjdk.org
Tue Oct 18 12:59:11 UTC 2022


On Mon, 27 Apr 2020 11:43:28 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

> This fixes a bug where the first call to unbind would clear the internal invalidation listener used, resulting in subsequent unbind calls to be no-ops, unless bind was called again first.
> 
> I had to rewrite the parameterized test slightly as Parameterized will only call the parameters method once, and my new test modifies the internal state of the bindings used as parameters (by doing some unbind calls) which was making other tests fail.

Yes, it did fall through the cracks. I wasn't sure it was still relevant, but since it is, I'll put it on my queue.

Perhaps either @arapte or @nlisker can be the second reviewer.

-------------

PR: https://git.openjdk.org/jfx/pull/198


More information about the openjfx-dev mailing list