RFR: JDK-8295236: Update JavaDoc in javafx.geometry.Point3D [v5]
Douglas Held
duke at openjdk.org
Wed Oct 19 12:51:22 UTC 2022
On Wed, 19 Oct 2022 12:34:15 GMT, Douglas Held <duke at openjdk.org> wrote:
>> The JavaDoc for equals had a copy/paste error. I normalized the text based on the JavaDoc for method java.awt.Point#equals. ~~I also changed formatting in the method signatures of equals(), hashCode() and toString().~~
>>
>> For good measure, some kind of copy/paste detection should probably be added to the many automated checks. For the entire OpenJDK project.
>
> Douglas Held has updated the pull request incrementally with one additional commit since the last revision:
>
> Update Point3D.java
>
> Per review
I think there's something else of quality worth discussing here. Is `==` appropriate given the values under comparison are `double`?
-------------
PR: https://git.openjdk.org/jfx/pull/913
More information about the openjfx-dev
mailing list