RFR: 8294589: MenuBarSkin: memory leak when changing skin [v8]

Andy Goryachev angorya at openjdk.org
Wed Oct 19 15:49:17 UTC 2022


> Fixed memory leak by using weak listeners and making sure to undo everything that has been done to MenuBar/Skin in dispose().
> 
> This PR depends on a new internal class ListenerHelper, a replacement for LambdaMultiplePropertyChangeListenerHandler.
> See https://github.com/openjdk/jfx/pull/908

Andy Goryachev has updated the pull request incrementally with three additional commits since the last revision:

 - Merge branch '8294809.listener.helper' into 8294589.menubarskin.leak
 - Revert "8294809: removed weak listeners support"
   
   This reverts commit 2df4a85db638d76cacaf6c54ba669cdb3dd91a18.
 - Revert "8294589: removed weak listeners"
   
   This reverts commit 2ea27fc912178cf2f22155794e047f20950d0d7d.

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/906/files
  - new: https://git.openjdk.org/jfx/pull/906/files/2ea27fc9..92418aaf

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=906&range=07
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=906&range=06-07

  Stats: 649 lines in 3 files changed: 643 ins; 1 del; 5 mod
  Patch: https://git.openjdk.org/jfx/pull/906.diff
  Fetch: git fetch https://git.openjdk.org/jfx pull/906/head:pull/906

PR: https://git.openjdk.org/jfx/pull/906


More information about the openjfx-dev mailing list