RFR: WIP: 8260528: Clean glass-gtk sizing and positioning code [v5]

Thiago Milczarek Sayao tsayao at openjdk.org
Thu Oct 20 17:25:00 UTC 2022


On Thu, 20 Oct 2022 17:04:31 GMT, Thiago Milczarek Sayao <tsayao at openjdk.org> wrote:

>> This cleans size and positioning code, reducing special cases, code complexity and size.
>> 
>> Changes:
>> 
>> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different sizes. It does not assume any size because it varies - it does cache because it's unlikely to vary on the same system - but if it does occur, it will only waste a resize event.
>> - frame extents are received in process_property_notify;
>> - window geometry, min/max size are centralized in update_window_constraints and uses  `XSetWMNormalHints` because it supports initial position;
>> - window_configure: Changes can be requested directly to the window manager with `XReconfigureWMWindow` - it's compatible with `windowChangesMask`, `windowChanges`;
>> - request_focus uses `_NET_ACTIVE_WINDOW` directly as it does not seem to have focus stealing problems.
>> 
>> I have left some debug print statements which will be removed when we finish testing.
>
> Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove debug statements

Found a bug that sometimes windows pops up on wrong location, back to WIP.

-------------

PR: https://git.openjdk.org/jfx/pull/915


More information about the openjfx-dev mailing list