RFR: WIP: 8260528: Clean glass-gtk sizing and positioning code [v13]

Thiago Milczarek Sayao tsayao at openjdk.org
Mon Oct 24 15:00:05 UTC 2022


On Mon, 24 Oct 2022 14:51:55 GMT, Thiago Milczarek Sayao <tsayao at openjdk.org> wrote:

>> This cleans size and positioning code, reducing special cases, code complexity and size.
>> 
>> Changes:
>> 
>> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different sizes. It does not assume any size because it varies - it does cache because it's unlikely to vary on the same system - but if it does occur, it will only waste a resize event.
>> - window geometry, min/max size are centralized in update_window_constraints;
>> - Frame extents (the window decoration size used for "total window size":
>>     - frame extents are received in process_property_notify;
>>     - removed quirks in java code;
>>     - When received, call set_bounds again to adjust the size;
>> - `gtk_window_set_focus_on_map` to fix https://bugs.openjdk.org/browse/JDK-8292922 and re-fix  https://bugs.openjdk.org/browse/JDK-8271054
>> - `windowGeometry->final_width.type`, `windowGeometry->final_height.type` simplified to `windowGeometry->bounds_type` because there's no mixed size orientation (i think :));
>> - `requested_bounds` removed - not necessary;
>> - `window_configure` incorporated in set_bounds with `gtk_window_move` and `gtk_window_resize`
>
> Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Raise window on map

@johanvos I think is coming into shape. If you want you can take a look.

-------------

PR: https://git.openjdk.org/jfx/pull/915


More information about the openjfx-dev mailing list