RFR: 8290844: Add Skin.install() method [v13]
Kevin Rushforth
kcr at openjdk.org
Thu Oct 27 15:58:01 UTC 2022
On Thu, 27 Oct 2022 15:50:06 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 26 additional commits since the last revision:
>>
>> - Merge remote-tracking branch 'origin/master' into 8290844.skin.install
>> - 8290844: review comments
>> - Merge remote-tracking branch 'origin/master' into 8290844.skin.install
>> - 8290844: javadoc
>> - Merge remote-tracking branch 'origin/master' into 8290844.skin.install
>> - 8290844: javadoc
>> - Merge branch 'openjdk:master' into 8290844.skin.install
>> - 8290844: unit tests
>> - Merge remote-tracking branch 'origin/master' into 8290844.skin.install
>> - 8290844: review comments
>> - ... and 16 more: https://git.openjdk.org/jfx/compare/9bab17bd...4aaf422b
>
> modules/javafx.controls/src/main/java/javafx/scene/control/Control.java line 226:
>
>> 224: * <p>
>> 225: * To ensure a one-to-one relationship between a {@code Control} and its {@code Skin},
>> 226: * setting the {@link #skinProperty() skin property} to a non-null {@code Skin} first checks
>
> This need not be a link, since it is already in the skin property. I recommend changing it to code style.
Actually, it's better to just remove the link and leave it as plain text.
-------------
PR: https://git.openjdk.org/jfx/pull/845
More information about the openjfx-dev
mailing list