RFR: 8290844: Add Skin.install() method [v15]

[Kevin Rushforth]

On Thu, 27 Oct 2022 17:16:02 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> - added Skin.install()
>> - javadoc changes for Skinnable.setSkin(Skin)
>
> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 28 additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'origin/master' into 8290844.skin.install
>  - 8290844: review comments
>  - Merge remote-tracking branch 'origin/master' into 8290844.skin.install
>  - 8290844: review comments
>  - Merge remote-tracking branch 'origin/master' into 8290844.skin.install
>  - 8290844: javadoc
>  - Merge remote-tracking branch 'origin/master' into 8290844.skin.install
>  - 8290844: javadoc
>  - Merge branch 'openjdk:master' into 8290844.skin.install
>  - 8290844: unit tests
>  - ... and 18 more: https://git.openjdk.org/jfx/compare/2c98cac5...3235d433

modules/javafx.controls/src/main/java/javafx/scene/control/Skinnable.java line 46:

> 44:      * and its {@code Skin}. Every {@code Skin} maintains a back reference to the
> 45:      * {@code Skinnable}.  When required, this relationship is enforced when the {@code Skin} is set,
> 46:      * throwing an {@code IllegalArgumentException}.

It looks like you removed too much. I think you need to retain the information about what will cause the exception. Maybe something like `,throwing an {@code IllegalArgumentException} if the return value of {@link Skin#getSkinnable()} is not the same as this {@code Skinnable}.`?

-------------

PR: https://git.openjdk.org/jfx/pull/845