RFR: 8254676: Alert disables Tab selection when TabDragPolicy REORDER is used
Kevin Rushforth
kcr at openjdk.org
Thu Oct 27 23:00:38 UTC 2022
On Sun, 11 Sep 2022 12:13:47 GMT, Johan Vos <jvos at openjdk.org> wrote:
> Don't set TabHeader to mouseTransparent, since it might get stuck in that state (e.g. in case an Alert is shown).
> The TabPaneSkin deals with the dragging internally, and does not require the dragged node to be mouseTransparent.
The fix looks fine to me. I tested it and all is as expected.
I also don't remember the reason for the initial setting of `mouseTransparent`, but it was in the initial implementation of draggable tabs [JDK-8187074](https://bugs.openjdk.org/browse/JDK-8187074). Johan's guess seems plausible.
-------------
Marked as reviewed by kcr (Lead).
PR: https://git.openjdk.org/jfx/pull/895
More information about the openjfx-dev
mailing list