RFR: 8290844: Add Skin.install() method [v15]

John Hendrikx jhendrikx at openjdk.org
Fri Oct 28 08:02:22 UTC 2022


On Thu, 27 Oct 2022 23:36:58 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Are we mixing?  I believe the tests have been converted to JUnit5 some time ago, [JDK-8292678](https://bugs.openjdk.org/browse/JDK-8292678) at least in Eclipse.
>> I think this is a valid change.
>
> (and it was me who added @Test(expected=IllegalArgumentException.class) test)

I said it wrong, the asserts can be used in both 4 and 5, so `assertThrows` can always be used now that it is available (the upgrade to JUnit 5 also updated JUnit 4 to a version which supports `assertThrows`).

-------------

PR: https://git.openjdk.org/jfx/pull/845


More information about the openjfx-dev mailing list