RFR: 8290844: Add Skin.install() method [v15]

John Hendrikx jhendrikx at openjdk.org
Fri Oct 28 08:05:38 UTC 2022


On Thu, 27 Oct 2022 17:34:16 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> modules/javafx.controls/src/main/java/javafx/scene/control/Skinnable.java line 46:
>> 
>>> 44:      * and its {@code Skin}. Every {@code Skin} maintains a back reference to the
>>> 45:      * {@code Skinnable}.  When required, this relationship is enforced when the {@code Skin} is set,
>>> 46:      * throwing an {@code IllegalArgumentException}.
>> 
>> It looks like you removed too much. I think you need to retain the information about what will cause the exception. Maybe something like `,throwing an {@code IllegalArgumentException} if the return value of {@link Skin#getSkinnable()} is not the same as this {@code Skinnable}.`?
>
> corrected, thanks!

I sort of left that out on purpose, since I think that's too much detail for an interface description.  The relationship is enforced, and it's not up to the docs to describe the exact mechanism (or future mechanisms).

-------------

PR: https://git.openjdk.org/jfx/pull/845


More information about the openjfx-dev mailing list