RFR: 8294809: ListenerHelper for managing and disconnecting listeners [v6]

[Andy Goryachev]

On Thu, 27 Oct 2022 17:17:40 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 20 additional commits since the last revision:
>> 
>>  - 8294809: map change listener
>>  - Merge remote-tracking branch 'origin/master' into 8294809.listener.helper
>>  - 8294809: generics
>>  - 8294809: is alive
>>  - Revert "8294809: removed weak listeners support"
>>    
>>    This reverts commit 2df4a85db638d76cacaf6c54ba669cdb3dd91a18.
>>  - 8294809: removed weak listeners support
>>  - 8294809: use weak reference correctly this time
>>  - 8294809: tests
>>  - 8294809: remove
>>  - 8294809: change listener with callback
>>  - ... and 10 more: https://git.openjdk.org/jfx/compare/a4fc7a68...7a1fa625
>
> modules/javafx.controls/src/main/java/javafx/scene/control/SkinBase.java line 241:
> 
>> 239:      */
>> 240:     // TODO I would like to deprecate and remove these methods, and replace them by listenerHelper().add**()
>> 241:     protected final void registerChangeListener(ObservableValue<?> observable, Consumer<ObservableValue<?>> operation) {
> 
> I don't think we want to deprecate this. It is part of the public API, so there would need to be a compelling reason to deprecate it.

we can keep it, eventually replacing the implementation with ListenerHelper, see [JDK-8296076](https://bugs.openjdk.org/browse/JDK-8296076)

-------------

PR: https://git.openjdk.org/jfx/pull/908