RFR: 8290844: Add Skin.install() method [v4]

Kevin Rushforth kcr at openjdk.org
Thu Sep 1 21:55:59 UTC 2022


On Wed, 24 Aug 2022 16:16:41 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

> the problem, as i see it, is that dispose() of the previous skin is executed after the new skin is attached. literally nothing can be done to work around the issues caused by this design mistake, but to fix it outright - dispose() the old skin first, then install the new one.
> 
> then, and only then, all the requirements concerning user-settable properties and clean uninstallation can be met.

I agree with this conclusion. What might help is a concrete example of an application that would hit this bug, and an explanation of how the app would fail. That way we'll know that this new API is enabling the fixing of actual (as opposed to theoretical) problems.

-------------

PR: https://git.openjdk.org/jfx/pull/845


More information about the openjfx-dev mailing list