RFR: 8290040: Provide simplified deterministic way to manage listeners [v2]

John Hendrikx jhendrikx at openjdk.org
Sun Sep 4 19:49:48 UTC 2022


On Wed, 31 Aug 2022 17:07:17 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Rename showing property to shown as it is already used in subclasses
>
> modules/javafx.base/src/main/java/javafx/beans/value/ObservableValue.java line 271:
> 
>> 269:      * for garbage collection while source isn't. However, using {@code when} this {@code ObservableValue}
>> 270:      * can still be eligible for garbage collection when the condition is {@code false} and the
>> 271:      * conditional itself is also eligible for garbage collection.
> 
> Wasn't this explained in the previous paragraph?

I rephrased it now as per your suggestion.

-------------

PR: https://git.openjdk.org/jfx/pull/830


More information about the openjfx-dev mailing list