RFR: 8293368: GitHub Workflows security hardening
Alex
duke at openjdk.org
Mon Sep 5 17:44:43 UTC 2022
This PR adds explicit [permissions section](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions) to workflows. This is a security best practice because by default workflows run with [extended set of permissions](https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token) (except from `on: pull_request` [from external forks](https://securitylab.github.com/research/github-actions-preventing-pwn-requests/)). By specifying any permission explicitly all others are set to none. By using the principle of least privilege the damage a compromised workflow can do (because of an [injection](https://securitylab.github.com/research/github-actions-untrusted-input/) or compromised third party tool or action) is restricted.
It is recommended to have [most strict permissions on the top level](https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions) and grant write permissions on [job level](https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs) case by case.
-------------
Commit messages:
- Update submit.yml
Changes: https://git.openjdk.org/jfx/pull/889/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=889&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8293368
Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod
Patch: https://git.openjdk.org/jfx/pull/889.diff
Fetch: git fetch https://git.openjdk.org/jfx pull/889/head:pull/889
PR: https://git.openjdk.org/jfx/pull/889
More information about the openjfx-dev
mailing list