RFR: 8290844: Add Skin.install() method [v2]

Kevin Rushforth kcr at openjdk.org
Wed Sep 7 20:58:58 UTC 2022


On Thu, 11 Aug 2022 12:16:35 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8290844: javadoc
>
> modules/javafx.controls/src/main/java/javafx/scene/control/Skin.java line 33:
> 
>> 31:  * An interface for defining the visual representation of user interface controls
>> 32:  * by defining a scene graph of nodes to represent the skin.
>> 33:  * A user interface control is abstracted behind the {@link Skinnable} interface.
> 
> shouldn't that be _to represent the skinnable_?

I think what @kleopatra meant was that the portion of the sentence _after_ the one you changed should read:


 * by defining a scene graph of nodes to represent the skinnable.


I think she's right. The scene graph of nodes _is_ the implementation of the Skin, which represents the Skinnable. I wonder if it would be clearer to just remove that last part and put a period after `user interface controls`?

-------------

PR: https://git.openjdk.org/jfx/pull/845


More information about the openjfx-dev mailing list