RFR: 8290844: Add Skin.install() method [v3]
Andy Goryachev
angorya at openjdk.org
Fri Sep 9 20:43:47 UTC 2022
On Wed, 7 Sep 2022 19:07:14 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> So javadoc tool ignores the interface, resulting in Control.setSkin(skin) method inheriting the property's description.
>>
>> Curiously, eclipse does show the interface's version, which I think helps more than having three identical descriptions for the property, its getter and setter.
>>
>> What would you recommend we do here?
>
> I recommend that we follow the existing practice of only putting the docs on the `xxxProperty` method, which includes removing the docs from `{set|get}Skin` in `Skinnable`, `Control`, and `PopupControl`. I checked it and it does what I would expect (except for a minor issue in that the `@throws` doesn't generate any docs, but since the Description indicates the conditions under which it will throw IAE, that's not a big problem; I'll file an RFE against the javadoc tool).
done
-------------
PR: https://git.openjdk.org/jfx/pull/845
More information about the openjfx-dev
mailing list