RFR: 8089280: horizontal scrollbar should never become visible in TableView with constrained resize policy

Andy Goryachev angorya at openjdk.org
Fri Sep 9 21:40:18 UTC 2022


On Fri, 9 Sep 2022 21:30:50 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Modified the tree/table view internals to suppress the horizontal (a.k.a. breadth in VirtualFlow) scroll bar when a constrained resize mode is in effect.  This change complements fixes added in [JDK-8089009](https://bugs.openjdk.org/browse/JDK-8089009) without addressing other bugs found in https://bugs.openjdk.org/browse/JDK-8292810
>> 
>> This PR might need a CSR since a public method is added to VirtualFlow:
>> 
>> 
>>     /**
>>      * Suppresses the breadth bar from appearing.
>>      */
>>     public void setSuppressBreadthBar(boolean suppress) {
>>         this.suppressBreadthBar = suppress;
>>     }
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableViewSkinBase.java line 898:
> 
>> 896:     }
>> 897: 
>> 898:     protected void updateSuppressBreadthBar() {
> 
> This should be package-scope.

good point

> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java line 2383:
> 
>> 2381:      * Suppresses the breadth bar from appearing.
>> 2382:      */
>> 2383:     public void setSuppressBreadthBar(boolean suppress) {
> 
> This should be package-scope.

yes

-------------

PR: https://git.openjdk.org/jfx/pull/894


More information about the openjfx-dev mailing list