RFR: 8089280: horizontal scrollbar should never become visible in TableView with constrained resize policy [v2]

[Andy Goryachev]

On Sat, 10 Sep 2022 15:13:22 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8089280: added tests
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java line 307:
> 
>> 305:     private boolean needLengthBar;
>> 306:     private boolean tempVisibility = false;
>> 307:     private boolean suppressBreadthBar;
> 
> Suggestion (optional) : You might want to explicitly initialize this to `false`, since we rely on this for other controls (e.g., `ListView`) which don't call `setSuppressBreadthBar`. (yes, I know Java will initialize it to false anyway, but setting it explicitly could be helpful to a reader of the code)

I would argue otherwise: not only it adds visual noise, but any time one steps into the constructor in a debugger, it goes through every field assignment.

-------------

PR: https://git.openjdk.org/jfx/pull/894