RFR: 8293839: Documentation memory consistency effects of runLater [v2]

Kevin Rushforth kcr at openjdk.org
Fri Sep 16 15:18:02 UTC 2022


On Thu, 15 Sep 2022 11:56:56 GMT, Jens Lidestrom <duke at openjdk.org> wrote:

>> Prior to this change it was not clear from the documentation if callers of Platform#runLater must perform
>> any synchronisation to have writes of the calling thread be visible in the JavaFX Application
>> Thread. It is important to document either if callers can rely on runLater to do such synchronisation
>> internally, or to document is users CAN NOT rely on runLater for this.
>> 
>> This change documents that actions in a thread prior to submitting a runnable to
>> Platform#runLater happen-before actions performed by the runnable in the JavaFX
>> Application Thread.
>> 
>> runLater inherits the memory consistency effects of InvokeLaterDispatcher in most cases. 
>> InvokeLaterDispatcher uses BlockingDeque internally. This change documents this
>> in the same way as it is documented by BlockingDeque.
>> 
>> Other implementations of runLater should have similar memory consistency effects.
>
> Jens Lidestrom has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use code formatting for 'runnable'

Looks good.

-------------

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.org/jfx/pull/872


More information about the openjfx-dev mailing list