RFR: 8292353: TableRow vs. TreeTableRow: inconsistent visuals in cell selection mode [v11]

[Ajit Ghaisas]

On Mon, 19 Sep 2022 15:44:58 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> The issue is caused by TreeTableRow incorrectly selected when cell selection mode is enabled.
>> 
>> Changes:
>> - modified TreeTableRow.updateSelection()
>
> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8292353: review comments

Changes requested by aghaisas (Reviewer).

modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlUtils.java line 201:

> 199:     /**
> 200:      * Finds a Node given the selector and predicate filter, then insures there is
> 201:      * one one such node

Comment has a typo : "one one"?

modules/javafx.controls/src/test/java/test/javafx/scene/control/TreeAndTableViewTest.java line 61:

> 59:     }
> 60: 
> 61:     /** TreeTableView with cell selection enabled should not select TreeTableRows */

Comment needs correction. `TreeTableView` should be `TableView` & `TreeTableRows` should be `TableRows`

modules/javafx.controls/src/test/java/test/javafx/scene/control/TreeTableRowTest.java line 840:

> 838:     /** TreeTableView with cell selection enabled should not select TreeTableRows */
> 839:     @Test
> 840:     public void test_TreeTableView_jdk_8292353_select_all() {

This test passes with or without the code changes.
If test intention is to increase coverage, then the comment `// JDK-8292353 failure` needs to be removed. If not, the test needs some correction.

modules/javafx.controls/src/test/java/test/javafx/scene/control/TreeTableRowTest.java line 875:

> 873:     /** TreeTableView with cell selection enabled should not select TreeTableRows */
> 874:     @Test
> 875:     public void test_TreeTableView_jdk_8292353_select_all_but_one() {

This test passes with or without the code changes.
If test intention is to increase coverage, then the comment `// JDK-8292353 failure` needs to be removed. If not, the test needs some correction.

-------------

PR: https://git.openjdk.org/jfx/pull/875