RFR: 8292353: TableRow vs. TreeTableRow: inconsistent visuals in cell selection mode [v12]
Andy Goryachev
angorya at openjdk.org
Wed Sep 28 18:23:45 UTC 2022
On Wed, 28 Sep 2022 16:20:59 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8292353: review comments
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/TableViewRowTest.java line 120:
>
>> 118: assertFalse(row.isSelected());
>> 119: }
>> 120: }
>
> Unless you are certain that they are covered elsewhere (not counting anything in `TreeAndTableViewTest`), having similar test methods to the above with cell selection disabled would be useful.
yes, these cases are covered in TableViewSelectionModelImplTest
-------------
PR: https://git.openjdk.org/jfx/pull/875
More information about the openjfx-dev
mailing list