RFR: JDK-8304933: BitSet (used for CSS pseudo class states) listener management is incorrect

Kevin Rushforth kcr at openjdk.org
Sat Apr 1 12:21:23 UTC 2023


On Mon, 27 Mar 2023 14:24:42 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

> BitSet uses the SetListenerHelper abstraction to prevent allocating the listener arrays.
> 
> When removing listeners, the newly returned listener helper (which may be different from the one called) is not reassigned. This effectively means that removing the listener does not happen.
> 
> This fix correctly assigns the potentially changed SetListenerHelper instance to BitSet's helper field after listener removal.

This seems like a pretty straight-forward change.

@hjohn can you add a (short) description of the fix to the PR?

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1071#issuecomment-1492955496


More information about the openjfx-dev mailing list