RFR: 8282359: Intermittent WebKit build failure on Windows: C1090: PDB API call failed, error code 23 [v3]

[Hima Bindu Meda]

On Mon, 3 Apr 2023 13:25:34 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Hima Bindu Meda has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove white space
>
> modules/javafx.web/src/main/native/Source/cmake/OptionsMSVC.cmake line 114:
> 
>> 112: if (NOT WTF_CPU_X86)
>> 113:     if (PORT STREQUAL "Java")
>> 114:     # Create pdb files for debugging purposes, also for Release builds
> 
> Now that this is in an "if...Java" block, the comment is misleading. Maybe change it to something like "Suppress creation of pdb files for Release builds" and also add a "FIXME" or "TODO" to re-enable them for debug builds?

Done

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1079#discussion_r1156334650