RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v7]

[Jose Pereda]

On Mon, 3 Apr 2023 22:55:16 GMT, Martin Fox <duke at openjdk.org> wrote:

>> tests/manual/events/KeyboardTest.java line 79:
>> 
>>> 77:  */
>>> 78: 
>>> 79: public class KeyboardTest extends Application {
>> 
>> Could you clarify how to run the test and what one should expect?
>> 
>> In my case, I'm running from Mac, with a Spanish physical keyboard, but changed to German keyboard from Keyboard -> Input sources -> German, and whether the Keyboard viewer is visible or not, I get:
>> 
>> [Mac] Testing 78 keys on German without combinations
>> Failed: code Numpad 0 did not produce any events
>> ...
>> Failed: code Decimal did not produce any events
>> Tested 78 keys with 76 failures
>> 
>> Is that expected? Is that test only meant for a German keyboard?
>
> @jperedadnr You set up the test correctly. I think you need to need to allow the 'terminal' application to use the accessibility API so the Java robot can send keyboard events. I can't provide you with the exact setting since I'm away from my Mac until the end of this week. When I get back I'll send details and add a comment to the test file. Apologies, I set up my Mac so long ago I forgot about this hiccup.

Great, that helps: after enabling Dock -> Privacy&Security -> Accessibility -> Terminal, tests for all 5 keyboards work, but only "without combinations":

[Mac] Testing 83 keys on U.S. English without combinations
Tested 83 keys with 0 failures
...
[Mac] Testing 78 keys on German without combinations
Tested 78 keys with 0 failures

However, without Keypad/All combinations fail:

[Mac] Testing 80 keys on French with all combinations
Failed: code A did not match combination 'A'
...
Failed: code Minus did not match combination '_'
Tested 80 keys with 45 failures
``` 
is that expected?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/425#discussion_r1156917274